[Performance] Optimize detectEOL#7702
Conversation
Refactor `detectEOL` to use a single pass through the string instead of `.match()`. This avoids allocating an intermediate array of matches, improving performance and memory usage, especially for large files.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
detectEOLfunction usedcontent.match(/\r\n|\n/g)which allocates an intermediate array of all matches. For large files, this can be an unnecessary performance and memory overhead.WHAT is this pull request doing?
Refactor
detectEOLto use a single loop to count\nand\r\noccurrences, avoiding array allocation and multiple passes.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 3151127233665845755 started by @gonzaloriestra