Skip to content

[Performance] Optimize detectEOL#7702

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-optimize-detect-eol-1740616999-3151127233665845755
Draft

[Performance] Optimize detectEOL#7702
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-optimize-detect-eol-1740616999-3151127233665845755

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The detectEOL function used content.match(/\r\n|\n/g) which allocates an intermediate array of all matches. For large files, this can be an unnecessary performance and memory overhead.

WHAT is this pull request doing?

Refactor detectEOL to use a single loop to count \n and \r\n occurrences, avoiding array allocation and multiple passes.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 3151127233665845755 started by @gonzaloriestra

Refactor `detectEOL` to use a single pass through the string instead of `.match()`. This avoids allocating an intermediate array of matches, improving performance and memory usage, especially for large files.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant