Skip to content

[Refactor] Use uniq helper in theme check #7699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
Jun 4, 2026
Merged

[Refactor] Use uniq helper in theme check #7699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/theme/src/cli/services/check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {fileExists, readFileSync, writeFile} from '@shopify/cli-kit/node/fs'
import {outputResult, outputInfo, outputSuccess} from '@shopify/cli-kit/node/output'
import {joinPath} from '@shopify/cli-kit/node/path'
import {renderInfo} from '@shopify/cli-kit/node/ui'
import {uniq} from '@shopify/cli-kit/common/array'
import {
Severity,
applyFixToString,
Expand Down Expand Up @@ -292,7 +293,7 @@ export async function outputActiveConfig(themeRoot: string, configPath?: string,

// Depending on how the configs were merged during loadConfig, there may be
// duplicate patterns to ignore. We can clean them before outputting.
ignore: [...new Set(ignore)],
ignore: uniq(ignore ?? []),

rootUri,

Expand All @@ -307,7 +308,7 @@ export async function outputActiveChecks(root: string, configPath?: string, envi
const {settings, ignore, checks} = await loadConfig(configPath, root)
// Depending on how the configs were merged during loadConfig, there may be
// duplicate patterns to ignore. We can clean them before outputting.
const ignorePatterns = [...new Set(ignore)]
const ignorePatterns = uniq(ignore ?? [])

const checkCodes = Object.keys(settings)

Expand Down
Loading