Make CI::Queue::Bisect#config public - #424
Merged
Merged
Conversation
Every other queue exposes `config` publicly through `CI::Queue::Common`. Consumers configure the queue while tests load (e.g. setting `config.test_id_normalizer` from a Rails initializer), and since `bisect_command` assigns `Minitest.queue` before loading tests, the private reader raises `NoMethodError` and aborts the bisect. Co-authored-by: Aiden Storey <aiden.storey@shopify.com>
Configuration#initialize does not accept failing_test as a keyword; set it via the accessor instead, and use a Tempfile rather than a hardcoded /tmp path. Assisted-By: devx/a7dfa242-697c-48e5-8e5d-65c25452ceff
bitwise-aiden
force-pushed
the
ba-update-bisect-config
branch
from
August 18, 2026 17:03
15aa016 to
8a2faff
Compare
acaron
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other queue exposes
configpublicly throughCI::Queue::Common. Consumers configure the queue while tests load (e.g. settingconfig.test_id_normalizerfrom a Rails initializer), and sincebisect_commandassignsMinitest.queuebefore loading tests, the private reader raisesNoMethodErrorand aborts the bisect.