agentic(sibling): write result JSON to /workspace so the result guard finds it#2165
Merged
ichbinblau merged 1 commit intoJul 11, 2026
Conversation
The node-0 sibling client pinned AGENTIC_OUTPUT_DIR=/run_logs/slurm_job-* (host
/tmp), so the aggregated ${RESULT_FILENAME}_conc<N>.json landed outside
GITHUB_WORKSPACE and the workflow result-count guard failed with
"expected 1 agentic results, found 0" (run 29095134929, dsv4 c32).
The co-located path leaves AGENTIC_OUTPUT_DIR unset, defaulting to
INFMAX_CONTAINER_WORKSPACE=/workspace (host repo bind-mount == GITHUB_WORKSPACE).
Drop the override so the sibling matches: raw artifacts still go under the
trace_replay log dir (/run_logs), only the top-level result JSON moves to
/workspace where the guard/upload steps expect it.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the DSv4 agentic sibling-client run failing at the end with
Run failed: expected 1 agentic results, found 0.(e.g. run 29095134929,dsv4 ... c32).Root cause: the node-0 sibling client set
AGENTIC_OUTPUT_DIR=/run_logs/slurm_job-*(host/tmp), soprocess_agentic_result.pysaved the aggregated${RESULT_FILENAME}_conc<N>.jsonoutsideGITHUB_WORKSPACE. The workflow guard globs${RESULT_FILENAME}_conc*.jsoninGITHUB_WORKSPACEand found 0.The co-located path leaves
AGENTIC_OUTPUT_DIRunset, so it defaults toINFMAX_CONTAINER_WORKSPACE=/workspace— which is the host repo bind-mount (== GITHUB_WORKSPACE). Dropping the override makes the sibling match: raw artifacts still go under the trace_replay log dir (/run_logs), only the top-level result JSON moves to/workspacewhere the guard and upload steps expect it./workspaceis bind-mounted writable in the siblingdocker run, same as the co-located server container.Changes
benchmarks/multi_node/amd_utils/server_sglang.sh: remove theAGENTIC_OUTPUT_DIR=/run_logs/...line from the siblingclient.env(single line + explanatory comment).Test plan
dsv4-fp4-mi355x-sglang-disagg-agentic-hicache; confirmSaved aggregated agentic result to /workspace/${RESULT_FILENAME}_conc<N>.jsonand the result-count guard passes.LOGS/agentic/**) still upload.