[codex] support optional heterogeneous hardware metadata#2100
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
|
Claude finished @cquil11's task in 2m 49s —— View job PR Review: heterogeneous hardware metadata
LGTM - no blocking issues found Verified during review:
Notes per review checklist: no master configs were modified (no perf-changelog entry needed), and |
Adds optional
hardwaremetadata inside theprefillanddecodeworker blocks for heterogeneous disaggregated multi-node configs. The fields must be specified together or both omitted; omission preserves the existing homogeneous behavior.disagg: trueis rejected for single-node configs.Worker metadata flows through generated matrices and workflows into both regular and agentic aggregate results as
prefill_hwanddecode_hw. It does not affect scheduling or launcher behavior, and no existing master config entries are modified.Validation:
186matrix-logic tests,28regular process-result tests, and26agentic process-result tests pass; all226active master entries validate successfully.Follow-up: #2105 tracks consolidating duplicated regular/agentic metadata processing into a shared helper.