Skip to content

fix: move dsv4-fp4-mi355x MTP scripts into fixed_seq_len/#1860

Merged
cquil11 merged 1 commit into
mainfrom
fix/dir-structure
Jun 19, 2026
Merged

fix: move dsv4-fp4-mi355x MTP scripts into fixed_seq_len/#1860
cquil11 merged 1 commit into
mainfrom
fix/dir-structure

Conversation

@cquil11

@cquil11 cquil11 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

The dsv4-fp4-mi355x-{sglang,vllm,atom}-mtp MTP benchmark scripts sat at benchmarks/single_node/ instead of benchmarks/single_node/fixed_seq_len/ with every other fixed-seq-len script.

runners/launch_mi355x-amds.sh resolves fixed-seq-len scripts to single_node/fixed_seq_len/<base>_<framework>_mtp.sh, so the launcher could not find them. No launcher/config change needed — the move aligns the files with the path the existing infra already expects.


Note

Low Risk
Path-only relocation of benchmark shell scripts; no serving flags or launcher logic changes.

Overview
Relocates the three DSv4 FP4 MI355X MTP benchmark shells (sglang, vllm, atom) from benchmarks/single_node/ into benchmarks/single_node/fixed_seq_len/, alongside the rest of the fixed-seq-len recipes.

runners/launch_mi355x-amds.sh already resolves MTP jobs to single_node/fixed_seq_len/<base>_<framework>_mtp.sh via SCENARIO_SUBDIR and SPEC_SUFFIX, so the scripts were previously in the wrong directory and the launcher could not find them. No launcher or config updates—only the file paths change.

Reviewed by Cursor Bugbot for commit 485c675. Bugbot is set up for automated code reviews on this repo. Configure here.

These three single-node MTP benchmark scripts were placed at
benchmarks/single_node/ instead of benchmarks/single_node/fixed_seq_len/.
The launcher (runners/launch_mi355x-amds.sh) resolves fixed-seq-len
scripts to single_node/fixed_seq_len/<base>_<framework>_mtp.sh, so the
dsv4-fp4-mi355x-{sglang,vllm,atom}-mtp config entries could not locate
them. Move aligns the files with the path the existing infra expects.
@cquil11 cquil11 requested a review from a team June 19, 2026 18:19
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.


感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致

如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。

如需更多帮助,PR 作者可通过 Slack 联系核心维护者。

@cquil11 cquil11 merged commit 6633e17 into main Jun 19, 2026
7 checks passed
@cquil11 cquil11 deleted the fix/dir-structure branch June 19, 2026 18:22
functionstackx added a commit that referenced this pull request Jul 4, 2026
PR #1860 moved the script from single_node/ into fixed_seq_len/ without
updating the relative source path, so every launch died with
'No such file or directory' before serving. One more ../ fixes it.

中文:修复 dsv4_fp4_mi355x_vllm_mtp.sh 中 benchmark_lib.sh 的相对
引用路径 - #1860 将脚本移入 fixed_seq_len/ 时未同步更新路径,导致
启动即报错。补一级 ../ 即可。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
functionstackx added a commit that referenced this pull request Jul 4, 2026
…est nightly / DeepSeek-V4 FP4 MI355X vLLM MTP:升级镜像至最新 nightly (#1981)

* [AMD] DeepSeek-V4 FP4 MI355X vLLM MTP: bump image to latest nightly

Update dsv4-fp4-mi355x-vllm-mtp from vllm/vllm-openai-rocm:v0.22.0 to the latest
nightly (nightly-09663abde0f50944a8d5ea30120666024b503faa). Note two-stage
attention kernels and AITER MLA in the changelog.

* chore(changelog): set pr-link for dsv4-fp4-mi355x-vllm-mtp image bump (#1981)

* docs(changelog): two-stage attention improves across all concurrency (mtp)

* [AMD] dsv4 fp4 mi355x vllm MTP: use AITER MoE backend

* Fix benchmark_lib.sh source path in dsv4_fp4_mi355x_vllm_mtp.sh

PR #1860 moved the script from single_node/ into fixed_seq_len/ without
updating the relative source path, so every launch died with
'No such file or directory' before serving. One more ../ fixes it.

中文:修复 dsv4_fp4_mi355x_vllm_mtp.sh 中 benchmark_lib.sh 的相对
引用路径 - #1860 将脚本移入 fixed_seq_len/ 时未同步更新路径,导致
启动即报错。补一级 ../ 即可。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
functionstackx added a commit that referenced this pull request Jul 6, 2026
… will be deprepcated on july 6th, and were given an chance for comment period and everyone reacted notice] Deprecate gpt-oss-120b benchmark configs / 弃用 gpt-oss-120b 基准测试配置 (#2101)

Following the MiniMax M2.5/M2.7 deprecation pattern (#1874): all 10
gptoss config entries removed from the active master configs and
archived under configs/deprecated/{nvidia,amd}-gptoss-master.yaml; the
9 single-node scripts and the gb200 dynamo-trt multi-node script moved
into deprecated/ subdirectories. Unlike #1874, the moved scripts'
benchmark_lib.sh source paths are corrected for the extra directory
level (the #1860 bug class).

中文:按 MiniMax M2.5/M2.7 弃用模式(#1874)弃用 gpt-oss-120b 基准
测试配置 - 10 个配置条目从活动 master 配置中移除并归档至
configs/deprecated/,全部脚本移入 deprecated/ 子目录;与 #1874 不同,
本次已同步修正移动脚本中 benchmark_lib.sh 的相对引用路径。

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant