Skip to content

Update DSv4 B300 vllm#1221

Merged
functionstackx merged 10 commits into
mainfrom
nv/b300-vllm-mega-moe
Apr 29, 2026
Merged

Update DSv4 B300 vllm#1221
functionstackx merged 10 commits into
mainfrom
nv/b300-vllm-mega-moe

Conversation

@wzhao18

@wzhao18 wzhao18 commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Integrate Mega MoE backend and update vLLM image for the B300 DeepSeek-V4-Pro FP4 config (dsv4-fp4-b300-vllm).

Changes

Image Update

  • Bump container image from vllm/vllm-openai:deepseekv4-cu130vllm/vllm-openai:v0.20.0-cu130

Mega MoE Backend (Benchmark Script)

Search-Space Tuning (Master Config)

  • Reduce tp:8 (non-DP-attn) concurrency range: conc-end: 128conc-end: 4 for both 1k1k and 8k1k
  • Reduce tp:4 ep:4 dp-attn 8k1k concurrency range: conc-end: 1024conc-end: 512

Perf Changelog

  • Add dsv4-fp4-b300-vllm entry documenting the image bump and Mega MoE enablement

Sweep Results

@wzhao18
wzhao18 marked this pull request as ready for review April 29, 2026 02:30
@wzhao18
wzhao18 requested a review from a team April 29, 2026 02:30
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@claude

claude Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Claude finished @wzhao18's task in 1m 59s —— View job


Review of PR #1221

  • Gather context and read changed files
  • Validate master config and perf-changelog
  • Validate model prefixes and container images
  • Review benchmark script changes
  • Review workflow and matrix logic changes
  • Review launch script changes
  • Post review summary

Summary: The slurm-time-limit plumbing is clean end-to-end (master config → validation → sweep generator → workflow inputs → launch script with ${SLURM_TIME_LIMIT:-180} fallback). Image update to v0.20.0-cu130 and the Mega MoE backend gate look correct. Two issues flagged:

  1. 🟡 perf-changelog.yaml is missing pr-link — every other entry has one.
  2. 🟡 GMU_ARGS in dsv4_fp4_b300_vllm.sh is defined and expanded but never populated — either dead code or an incomplete --gpu-memory-utilization flag for the DP-attn path.

No blocking issues found.

Comment thread perf-changelog.yaml
Comment thread benchmarks/single_node/dsv4_fp4_b300_vllm.sh Outdated
Fields.SPEC_DECODING.value: spec_decoding,
Fields.EXP_NAME.value: f"{model_code}_{seq_len_str}",
Fields.DISAGG.value: disagg,
Fields.RUN_EVAL.value: False, # Default, may be overridden by mark_eval_entries

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Line Count Report

  • Total Lines: 966
  • Base Lines: 963
  • Change: 📈 +3 lines

Comment thread perf-changelog.yaml
Comment thread benchmarks/single_node/dsv4_fp4_b300_vllm.sh Outdated
@wzhao18 wzhao18 changed the title [WIP] Update DSv4 B300 vllm Update DSv4 B300 vllm Apr 29, 2026
@wzhao18

wzhao18 commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator Author

Ready for review. Once approved, will fix Run Sweep / check-newline (pull_request) @Oseltamivir @kedarpotdar-nv @jgangani

Sweep: https://github.com/SemiAnalysisAI/InferenceX/actions/runs/25118794641/job/73613407458?pr=1221

@kedarpotdar-nv

Copy link
Copy Markdown
Collaborator

@claude please update pr description

@Klaud-Cold

Klaud-Cold commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Claude finished @kedarpotdar-nv's task in 1m 43s —— View job


Updating PR Description

  • Gather context on PR changes
  • Draft updated PR description
  • Update PR description

PR description has been updated with a structured summary covering the image bump, Mega MoE backend gating, search-space tuning changes, and perf changelog entry.

View job

@functionstackx functionstackx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@functionstackx
functionstackx merged commit 182c80a into main Apr 29, 2026
12 of 17 checks passed
@functionstackx
functionstackx deleted the nv/b300-vllm-mega-moe branch April 29, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants