fix(inference): allow mixed engines in unofficial previews / 修复:允许非官方预览混合显示多个引擎#576
Merged
Merged
Conversation
Bypass production engine-family exclusions while an unofficial overlay is present so official and unofficial results can render, toggle, reset, and appear in tables together. Keep the guard unchanged for official-only comparisons.\n\n中文:非官方 overlay 预览期间绕过生产环境的引擎家族互斥规则,使官方与非官方结果可在同一图表中共同渲染、切换、重置并展示于表格中;纯官方对比仍保留原有互斥限制。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cd37863. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Follow-up to #575. Unofficial-run preview mode is diagnostic, so it should allow results from multiple engine families to remain visible on the same graph.
ScatterGraphhas unofficial overlay data.Root cause
#575 changed the sticky engine family from the official selection to the unofficial overlay. That made the overlay visible, but it still resolved the combined selection down to one engine family and hid the conflicting official series. Preview mode needs to bypass that restriction rather than choose which side wins.
Tests
tsc --noEmitoxlintandoxfmton changed filesscatter-graph.cy.tsx: 12 tests passed, including mixed-engine rendering, table rows, scope changes, legend selection, and the official-only guardOverlay support
This change applies specifically to
?unofficialrun=/?unofficialruns=previews. It covers both official and overlay data paths, respects active overlay hardware filters, and keeps dismissal/reset behavior intact. Preview deployment verification with a real unofficial run will be added once the deployment is available.中文说明
这是 #575 的后续修复。非官方 run 预览用于诊断和对比,因此同一图表应允许同时展示多个引擎家族的结果。
ScatterGraph存在非官方 overlay 数据时,绕过生产环境的引擎家族互斥规则。根因
#575 只是将“粘性”引擎家族从官方选择改为非官方 overlay。这样虽然能显示 overlay,但合并后的选择仍会被压缩为单一引擎家族,冲突的官方系列会被隐藏。预览模式不应决定哪一方优先,而应完全绕过这项限制。
测试
tsc --noEmitoxlint和oxfmtscatter-graph.cy.tsx:12 项通过,覆盖跨引擎渲染、表格行、范围切换、图例选择及纯官方限制Overlay 支持
本变更专门作用于
?unofficialrun=/?unofficialruns=预览,同时覆盖官方与 overlay 数据路径,遵守启用中的 overlay 硬件过滤,并保持关闭 run 与重置行为不变。部署可用后,将使用真实非官方 run 补充预览环境验证结果。Note
Medium Risk
Behavior changes only when unofficial overlay data is loaded, but it affects legend selection, table rows, and overlay reconciliation—areas users rely on for comparing runs across engines.
Overview
Unofficial-run preview (
?unofficialrun=) is treated as diagnostic: official and overlay series from different engine families can stay on the same chart and table instead of being collapsed to one family.ScatterGraphskipsresolveComparisonSelectionwheneveroverlayDatais present, so rendering and legend state keep the full combined selection. Legend toggles use plaincomputeToggleinstead of the productiontoggleComparisonSelectionguard, and reset selects all scoped series without overlay-preferring sticky resolution. Official-only charts still run the existing cross-engine exclusion.ChartDisplayaligns table/export row visibility with that policy: overlay scoping no longer runs the production comparison resolver, andvisibleComparisonRowsfilters official and overlay rows by active keys only.Cypress expectations are updated for mixed-engine preview (chart opacity, table row counts, scope changes).
Reviewed by Cursor Bugbot for commit cd37863. Bugbot is set up for automated code reviews on this repo. Configure here.