Repository navigation
Update selenium.version to v4.49.0 - #2813
Merged
Merged
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Selenium 4.49.0 drops the org.openqa.selenium.devtools.v150 package and bundles v151/v152/v153 instead, breaking compilation of the Java CDP examples. v153 matches the currently installed Chrome/CDP version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HGrgKsy5anjTsJLk9GHZqQ
diemol
approved these changes
Sep 10, 2026
diemol
added a commit
that referenced
this pull request
Sep 17, 2026
pom.xml was bumped to selenium.version 4.49.0 in #2813, but build.gradle's default System.getProperty fallback was left at 4.47.0. The two builds had diverged silently because the Maven step runs first and was already failing on the unrelated LogTest issue (previous commit), so the Gradle step's own compile failure - CdpApiTest.java/NetworkTest.java import org.openqa.selenium.devtools .v153, which doesn't exist in 4.47.0 - never got a chance to run. Align the default with pom.xml so both build tools compile against the same Selenium version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
diemol
added a commit
that referenced
this pull request
Sep 17, 2026
…2831) * Restore translated documentation pages removed by the Docsy upgrade Commit 782404f (Hugo docsy upgrade, #2771) deleted 209 translated pages (70 ja, 69 pt-br, 70 zh-cn) as a side effect of a Hugo 0.155+ behavior change: aliases on a non-default-language page now publish relative to that language's own site root, not the global publish root (gohugoio/hugo#14388). These pages carried legacy /documentation/<lang>/... aliases predating the 2021 site restructure, which a translated page can no longer own. Rather than fix the aliases, that commit deleted the pages outright and moved their alias URLs onto the corresponding English page instead. The translations themselves were not stale or unwanted, so this restores their pre-deletion content from 782404f^ and fixes the front matter so the pages build under current Hugo/Docsy: - Legacy /documentation/<lang>/... aliases are dropped from the translated page (Hugo 0.155+ rejects them there); the corresponding English page already carries them as redirects to English content, per 782404f's decision, and is left untouched. - Aliases already prefixed with the page's own language (/<lang>/documentation/...) have that prefix stripped, since Hugo now auto-prepends the page's language to each alias. - Where dropping all aliases left an empty `aliases: []`, the key is removed entirely to match sibling front matter conventions. No English (.en.md) content or examples/ files were changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Point cross-language refs back at restored translated pages The Hugo docsy upgrade commit (782404f) rewrote {{< ref >}} shortcodes in surviving translated pages to force lang="en" wherever the target page was one of the 209 translated pages it deleted, so readers wouldn't hit a broken link. Now that those 209 pages are restored, revert the lang="en" override on every occurrence whose target resolves to an existing page in the referring page's own language, so cross-links between translated pages point at translations again instead of forcing English. All 97 occurrences across 51 files resolved with high confidence (same directory, relative path, absolute /documentation/... path, or a unique sitewide filename match) and were reverted; a clean `hugo --minify` build with zero warnings confirms every reverted ref still resolves. The 3 remaining lang="en" occurrences in legacy/selenium_ide/html_runner.*.md are unrelated HTML markup (xml:lang="en" lang="en" in an example runner file), not ref shortcodes, and were left untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Add JS RemoteWebDriver examples to translated pages, fix Qodo findings JS examples (added to remote_webdriver.ja/pt-br/zh-cn.md, mirroring the gh-codeblock references already used in the English page for #2562/#2829): Basic Example, Uploads (with translated/matching Local File Detector note), Downloads (enable/list/download/delete), and Browser specific functionalities (with translated/matching note on JS returning the concrete driver class directly). Qodo findings resolved (all pre-existing content restored verbatim from before the Docsy-upgrade deletion, not introduced by the restoration): - Kotlin gh-codeblock paths in waits.*.md missing a leading slash (9x) - Indentation on restored gh-codeblock lines in finders.*.md/cookies.*.md - Observability TOC anchors (ja: 1, pt-br: 4) not matching their headings - waits.ja.md/zh-cn.md #is-displayed anchor -> localized heading anchor - driver_location.ja.md #driver-location -> localized service.ja.md anchor - GitHub line-range fragments missing the trailing L (#L73-74 -> #L73-L74) across options.*.md and bidi/logging.*.md - BrowingContext() typo -> BrowsingContext() in print_page.*.md - getting_started.pt-br.md #remote-webdriver -> #driver-remoto - getting_started.pt-br.md/zh-cn.md PATH fragments -> localized driver_location.md heading anchor; zh-cn RemoteWebDriver link -> removed nonexistent #远程驱动 fragment - getting_started.ja.md #event-bus -> localized components.ja.md anchor - endpoints.pt-br.md #grid-status/#drain-node -> localized anchors, matching the English source's #grid-status/#drain-node targets Each anchor fix was verified against the actual target heading text, not just Qodo's suggestion. Shortcode balance (tabpane/tab open-close) verified across all 28 touched files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ko4CniqqrtSVntSMKyQrqq * Fix remaining Qodo findings: convert unsynced code examples to gh-codeblock Resolves the 6 structural "rule violation" findings (Qodo items 1-6): translated pages restored plain fenced code for topics that had never been wired up to the tracked examples/ source, so fixes to those snippets couldn't propagate. Added real, verified example source and replaced the fenced blocks with gh-codeblock references in ja/pt-br/zh-cn: - Fluent API / GoogleSearchPage and Domain Specific Language / AccountPage (test_practices/encouraged/*): illustrative pattern demos referencing fictional types, following the existing @test @disabled("Illustrative only: ...") precedent already used in design_strategies/BestPractices.java for the same kind of non-live-testable page-object example. The DSL page's original PageFactory.newInstance(Class) call also no longer compiles against 4.49.0 (removed API) - updated to PageFactory.initElements(driver, Class). Left the loginTest() snippet using `do.something()` as prose (not real code - `do` is a reserved word). - Fresh browser per test (zh-cn only): trivial `new FirefoxDriver()`. - Grid getting_started metadata example: real RemoteWebDriver session with se:name/se:sampleMetadata capabilities. Dropped the browserVersion/platformName capabilities from the old snippet (Windows on a Mac host, arbitrary version) since they made session creation against the real local standalone Grid hang indefinitely waiting for a non-existent matching node - the metadata capabilities are what the section is actually about. - Proxy examples (Java/CSharp/JavaScript/Kotlin - Python/Ruby already had real gh-codeblock-backed versions): rewrote as capability-verification tests instead of live browser launches, after discovering that setting a WebDriver-level Proxy capability makes Selenium Manager route its own browser/driver discovery network calls through that (fake) proxy, which always fails/hangs without a real proxy server - a genuine, by-design Selenium Manager behavior, not something fixable via a different placeholder value. Also swapped the non-parseable `<HOST:PORT>` placeholder for `myproxy.com:8080`, matching the already-working Python/Ruby examples' convention. - Removed the now-stale {{< badge-examples >}} flag from the options.md proxy tabpane now that all 6 bindings are real. Verified: mvn test (Java: ThreadGuardTest, FreshBrowserPerTestTest, GettingStartedTest, OptionsTest - all passing), dotnet test (OptionsTest.SetsProxy - passing), mvn test (Kotlin OptionsTest - passing), npx mocha test/drivers/*.spec.js (JS, 8/8 passing). Full test-compile clean across Java/Kotlin, dotnet build clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ko4CniqqrtSVntSMKyQrqq * Remove outer CI retry wrapper for Java example tests The Maven/Gradle test steps in java-examples.yml were wrapped in nick-invision/retry (max_attempts: 3), stacked on top of Surefire's own rerunFailingTestsCount: 3 in pom.xml. A genuinely failing test was retried up to 3 x 4 = 12 times, burning ~30 minutes of CI time before failing anyway. Drop the outer wrapper and rely on Surefire's native rerun for flaky-test recovery. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix stale stack-frame-count assertion in LogTest testRetrieveStacktraceForALog has failed deterministically in CI since 2026-09-09 (filed as #2833): Chrome no longer reports a separate stack frame for the inline onclick attribute handler, so the bar() -> foo() throw chain on logEntryAdded.html now yields 3 call frames instead of 4. Reproduced locally against current stable Chrome; update the expectation to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Give ConsoleLogs test more time for CDP events to arrive LoggingTest.ConsoleLogs timed out on Windows/nightly-Chrome CI waiting for two console-log events to round-trip over CDP within 5 seconds. Bump the wait to 10 seconds to cover that margin on slower CI runners. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Bump Gradle's default Selenium version to match pom.xml (4.49.0) pom.xml was bumped to selenium.version 4.49.0 in #2813, but build.gradle's default System.getProperty fallback was left at 4.47.0. The two builds had diverged silently because the Maven step runs first and was already failing on the unrelated LogTest issue (previous commit), so the Gradle step's own compile failure - CdpApiTest.java/NetworkTest.java import org.openqa.selenium.devtools .v153, which doesn't exist in 4.47.0 - never got a chance to run. Align the default with pom.xml so both build tools compile against the same Selenium version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.48.0→4.49.04.48.0→4.49.0Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.