Skip to content

fix: bind map shorthand syntax - #62

Draft
Seddryck wants to merge 1 commit into
mainfrom
codex/issue-59-open-expression-marker
Draft

fix: bind map shorthand syntax#62
Seddryck wants to merge 1 commit into
mainfrom
codex/issue-59-open-expression-marker

Conversation

@Seddryck

@Seddryck Seddryck commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • parse standalone map shorthand as an open_expression
  • represent MapShorthandSyntax as an ExpressionSyntax pipeline operation
  • preserve the authored |> form and expose its nested mapped OpenExpressionSyntax
  • keep closed-expression map shorthand boundaries intact
  • test root kind, syntax kind, children, source text, spans, arguments, and pipeline composition

Root cause

The grammar exposed standalone map_shorthand directly as a root expression. That prevented ExpressifSyntax.Parse("|> add(1)") from returning the expected outer OpenExpressionSyntax and initially left the C# binder without a valid typed path.

Validation

  • dotnet test bindings/csharp/Expressif.Syntax.Tests/Expressif.Syntax.Tests.csproj --no-restore --disable-build-servers --nologo -m:1 — 85/85 passed on net8.0, net9.0, and net10.0
  • npm run generate — passed
  • npx tree-sitter test — all 8 map-shorthand cases passed; 6 unrelated existing snapshots differ only by CRLF/LF behavior on Windows

Closes #59

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 452e13b0-acd7-4e63-86ea-18cd44e3acbf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Seddryck
Seddryck force-pushed the codex/issue-59-open-expression-marker branch from 9513e8e to 1e1c1f3 Compare August 16, 2026 23:27
@Seddryck
Seddryck force-pushed the codex/issue-59-open-expression-marker branch from 1e1c1f3 to 421cc90 Compare August 17, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open expressions should accept the leading pipeline marker

1 participant