Skip to content

fix: parse named function arguments - #61

Merged
Seddryck merged 1 commit into
mainfrom
codex/issue-60-named-arguments
Aug 16, 2026
Merged

fix: parse named function arguments#61
Seddryck merged 1 commit into
mainfrom
codex/issue-60-named-arguments

Conversation

@Seddryck

Copy link
Copy Markdown
Owner

Summary

  • accept named function arguments using parameter-name := value
  • preserve named arguments as lossless named_argument / NamedArgumentSyntax nodes
  • bind named and positional arguments in authored order while retaining .name as RecordAccessSyntax
  • add corpus and managed binding coverage for the reported expression, mixed arguments, and malformed input

Root cause

The function-call grammar restricted argument_list to positional_argument nodes, so valid named arguments could not be represented or bound.

Validation

  • npx tree-sitter generate
  • npx tree-sitter test — new named and mixed argument cases pass; 124/130 overall, with the remaining six existing snapshots differing only because the Windows checkout uses CRLF (\r versus \n and CST line rendering)
  • dotnet test bindings/csharp/Expressif.Syntax.Tests/Expressif.Syntax.Tests.csproj --no-restore --nologo — 82/82 passed on each of .NET 8, .NET 9, and .NET 10

Close #60

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 72fc1618-6244-4d61-baaa-3774239f5842


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Named arguments and parameter references should parse in function calls

1 participant