Skip to content

fix: allow closed expressions as arguments - #46

Merged
Seddryck merged 1 commit into
mainfrom
codex/fix-expression-composition
Aug 16, 2026
Merged

fix: allow closed expressions as arguments#46
Seddryck merged 1 commit into
mainfrom
codex/fix-expression-composition

Conversation

@Seddryck

Copy link
Copy Markdown
Owner

Summary

  • allow closed-expression pipelines directly inside positional arguments
  • preserve nested pipelines as the existing closed_expression CST node
  • bind nested closed expressions to ClosedExpressionSyntax
  • add valid composition, source-order, span, and malformed-input coverage
  • update affected invalid parameterized-expression recovery snapshots

This enables expressions such as:

append(.firstName | Titlecase)

Close #45.

Validation

  • npx tree-sitter test — 111/111 corpus cases passed
  • dotnet test bindings/csharp/Expressif.Syntax.Tests/Expressif.Syntax.Tests.csproj --nologo — 56/56 passed on each of .NET 8, .NET 9, and .NET 10

Environment note

The Node binding smoke test could not run because the local Node 24 native-addon rebuild fails on an existing Windows Release|Win32 project-configuration mismatch. This is unrelated to the grammar change.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b20205e6-2541-445d-94d5-1103116a1014


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function arguments should accept nested expressions

1 participant