Skip to content

Revamp SeaORM Tutorials (Issue #8)#9

Merged
billy1624 merged 47 commits intoSeaQL:masterfrom
shpun817:master
Jun 27, 2022
Merged

Revamp SeaORM Tutorials (Issue #8)#9
billy1624 merged 47 commits intoSeaQL:masterfrom
shpun817:master

Conversation

@shpun817
Copy link
Copy Markdown
Member

Comment thread tutorials-book/src/ch00-00-introduction.md
Comment thread tutorials-book/src/ch01-02-migration-cli.md
Comment thread tutorials-book/src/ch01-03-migration-api.md
Copy link
Copy Markdown
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely written! :)

Comment thread tutorials-book/src/ch00-00-introduction.md Outdated
@shpun817
Copy link
Copy Markdown
Member Author

Chapter 2 is ready for review. @billy1624

@tyt2y3
Copy link
Copy Markdown
Member

tyt2y3 commented Jun 23, 2022

So cool!

Copy link
Copy Markdown
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shpun817, I guess you updated the code? Making migration a module instead of a separate crate.

Which is differs from the project structure stated in section 1.2: https://github.com/shpun817/sea-orm-tutorial/blob/master/tutorials-book/src/ch01-02-migration-cli.md

And, then when I read on to section 1.3: https://github.com/shpun817/sea-orm-tutorial/blob/master/tutorials-book/src/ch01-03-migration-api.md. And in this section, the code is extended from section 1.1 instead of 1.2.

Should we update the code and make it able to run the migration via CLI and via migrator API?

Copy link
Copy Markdown
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to ignore seaql_migrations table in entity generation

Copy link
Copy Markdown
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shpun817, I have make some changes, please review and cherrypick the useful bits:

@billy1624
Copy link
Copy Markdown
Member

Btw... could you help me to resolve the merge conflict? Thanks!

@billy1624 billy1624 marked this pull request as ready for review June 27, 2022 07:37
@shpun817
Copy link
Copy Markdown
Member Author

shpun817 commented Jun 27, 2022

Ready to merge! @billy1624 @tyt2y3

Leftover tasks:

  • Add GitHub workflows for setting up the databases and running the examples, instead of just building them (reference: StarfishQL)
  • Add Chapter 3 - GraphQL Integration example

@billy1624 billy1624 merged commit e53392f into SeaQL:master Jun 27, 2022
Copy link
Copy Markdown
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice writing! @shpun817

@billy1624 billy1624 linked an issue Jun 30, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Plans to Revamp SeaORM Tutorial Use sea-orm migration

3 participants