Skip to content

fix(global-db): prove collision fast-path work - #659

Merged
ScriptedAlchemy merged 7 commits into
codex/tracedecay-total-redesign-planfrom
codex/globaldb-collision-fast-path-corrective
Aug 22, 2026
Merged

fix(global-db): prove collision fast-path work#659
ScriptedAlchemy merged 7 commits into
codex/tracedecay-total-redesign-planfrom
codex/globaldb-collision-fast-path-corrective

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

Replaces #653 from its last clean reviewed ancestry. The old PR branch was concurrently advanced with a rejected durable-counter/schema implementation, so this corrective PR carries only the behaviorally verified collision-authority patch.

  • records terminal identity-collision refusal and cursor coverage atomically
  • keeps only real-backed different-output provenance collisions convergent
  • preserves hard failure for ghost/same-output corruption
  • proves terminal re-admission never accesses the retained observation row and dispatches exactly one observation runtime command
  • preserves the corrupt-row tripwire and hides the observations table so even an ignored bare-column read fails
  • removes the former test-only identity-digest probe and feature wiring

Incoming candidate identity and payload digests are canonically produced upstream by DurableObservationV1::new; the marker branch consumes their private-field validated values and performs no digest operation of its own. This PR does not add redundant hashing for instrumentation. Runtime measurement is scoped to the observation adapter's actual read/submit dispatch boundaries, with a two-command full-path positive control and one-command terminal-path assertion.

Verification

Exact base: 26087ea7ae69baa2c52d5ae694394e82024c0e09
Exact head: 8a2e22ba62243757e4d98ba49abe33462474b6de

  • RED: renamed exact regression failed 0/1 because the mounted positive control observed 0 rather than 2 observation commands; SHA-256 a20b10fc7e4e845a8e1e1c27e3d4099d7f76cc687b71a9c72d45a6e8b7906853
  • GREEN: exact regression 1/1, 402 filtered; SHA-256 0e8d62d26a203c8c4d722cfa475bcfd1f8f699ea0fe021a9c99f8eff6c43e5b7
  • collision module: 18/18; SHA-256 49d930bdc8ae4d07236d4e582cad3a38d3a7f10619feca0d1c1b5daedcfcc17c
  • scoped global-db Clippy, locked, -D warnings: green; SHA-256 fdc9756e32763a471a76a64c2cc1c5f47e1582212a6043c77ec0d2f18d129b37
  • focused format, diff-check, and commitlint: green

No force push and no merge into master.

@changeset-bot

changeset-bot Bot commented Aug 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8a2e22b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5803ed0943

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/tracedecay-global-db/src/observation_adapter.rs Outdated
ScriptedAlchemy added a commit that referenced this pull request Aug 22, 2026
Checkpoint of the superseded durable-receipt lane after PR #653 was replaced by #659: removes the accumulate_admission_work write amplification (a durable write per re-admitted candidate), instruments begin_engine_read_snapshot as a traced runtime dispatch, dedupes merge-duplicated imports, and converts one of three covered-replay receipt assertions to the unchanged-receipt contract. Draft preserved for reference; not for merge.
@ScriptedAlchemy
ScriptedAlchemy merged commit 8e91fef into codex/tracedecay-total-redesign-plan Aug 22, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant