fix(global-db): prove collision fast-path work - #659
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5803ed0943
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Checkpoint of the superseded durable-receipt lane after PR #653 was replaced by #659: removes the accumulate_admission_work write amplification (a durable write per re-admitted candidate), instruments begin_engine_read_snapshot as a traced runtime dispatch, dedupes merge-duplicated imports, and converts one of three covered-replay receipt assertions to the unchanged-receipt contract. Draft preserved for reference; not for merge.
8e91fef
into
codex/tracedecay-total-redesign-plan
Summary
Replaces #653 from its last clean reviewed ancestry. The old PR branch was concurrently advanced with a rejected durable-counter/schema implementation, so this corrective PR carries only the behaviorally verified collision-authority patch.
observationstable so even an ignored bare-column read failsIncoming candidate identity and payload digests are canonically produced upstream by
DurableObservationV1::new; the marker branch consumes their private-field validated values and performs no digest operation of its own. This PR does not add redundant hashing for instrumentation. Runtime measurement is scoped to the observation adapter's actual read/submit dispatch boundaries, with a two-command full-path positive control and one-command terminal-path assertion.Verification
Exact base:
26087ea7ae69baa2c52d5ae694394e82024c0e09Exact head:
8a2e22ba62243757e4d98ba49abe33462474b6de0rather than2observation commands; SHA-256a20b10fc7e4e845a8e1e1c27e3d4099d7f76cc687b71a9c72d45a6e8b79068530e8d62d26a203c8c4d722cfa475bcfd1f8f699ea0fe021a9c99f8eff6c43e5b749d930bdc8ae4d07236d4e582cad3a38d3a7f10619feca0d1c1b5daedcfcc17c-D warnings: green; SHA-256fdc9756e32763a471a76a64c2cc1c5f47e1582212a6043c77ec0d2f18d129b37No force push and no merge into master.