Skip to content

refactor: delete hawk A unmounted surfaces (redundancy pair-scan, grammar blobs, hook reexports, startup-health wait, worker pool) - #523

Merged
ScriptedAlchemy merged 6 commits into
codex/tracedecay-total-redesign-planfrom
cursor/hawk-a-unmounted-deletions-9a29
Aug 19, 2026
Merged

refactor: delete hawk A unmounted surfaces (redundancy pair-scan, grammar blobs, hook reexports, startup-health wait, worker pool)#523
ScriptedAlchemy merged 6 commits into
codex/tracedecay-total-redesign-planfrom
cursor/hawk-a-unmounted-deletions-9a29

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

Deletes the hawk A items that have no production caller on this HEAD, verified per symbol with ripgrep before removal. No version bump.

Deleted

  • RedundantPair (runtime-core)crates/tracedecay-runtime-core/src/redundancy.rs carried a duplicate pair-scan family (RedundantPair, find_redundant_pairs, RedundancyPairScan, redundant_pair, connected_node_groups, push_unique_node) with zero callers outside the crate; the live scan in src/graph/redundancy_scan.rs defines its own private copies over RedundancyCandidate. Kept the shared scoring exports that the graph scan actually imports (Fingerprint, redundancy_match_score, body_token_window, compute_fingerprint, parse_file, round4).
  • Unused rust-grammar blobs — the NODE_TYPES/HIGHLIGHTS_QUERY/INJECTIONS_QUERY/TAGS_QUERY include_str! constants in tracedecay-code-extraction::ts_provider::rust_grammar and the vendor/tree-sitter-rust compatibility wrapper had zero callers (only LANGUAGE is used). The vendored asset files stay: the packaged-crate distribution acceptance and the [patch.crates-io] wrapper (live via tokensave-lite-treesitters) still reference them.
  • Unused hook reexports — 20 names re-exported from crates/tracedecay-hooks/src/lib.rs that no code inside or outside the crate references through the crate root: HookAdmissionLedgerError, HookAdmissionLedgerOpenReportV1, hook_admission_digest, HookConfigurationPublicationError, HookConfigurationPublicationOutcomeV1, HookConfigurationPublicationStoreV1, HookConfigurationReadStoreV1, MAX_HOOK_CONFIGURATION_BYTES, HookDeliverySpoolError, DecodedOpenCodeLspEventV1, NativeHookSignalV1, HOOK_SYNCHRONOUS_BUDGET_MICROS, HookSynchronousResultV1, deliver_feedback_with_rollback_async, HookReplayBatchV1, HookSpoolLimitsV1, HookSpoolOpenReportV1, HookSpoolResetReasonV1, HookSpoolWriterLeaseV1, hook_spool_checksum. The module items themselves stay reachable via their module paths.
  • wait_for_daemon_startup_health — its last production caller was removed in 3d5677e91 (retired update path). Deleting the wrapper orphans the whole private wait chain in src/doctor.rs (_with variant, progress/outcome types, classify/retryable/terminal/corruption helpers, startup probe args, database_recovery_guidance_for_problem, is_fts_only_corruption) and its tests, so the chain goes together instead of surviving as a test-only production port. The live doctor path (daemon_project_status, daemon_doctor_runtime_args, daemon_runtime_status, database_recovery_guidance) is untouched and its tests still pass.
  • WorkerPool — no Plan 25 caller exists (no v2 plan mentions the worker pool) and WorkerPool::new has zero callers anywhere, so the parent side is unmounted and the worker side (extract-worker hidden subcommand) can never be legitimately spawned. Deleted src/extraction_worker.rs, the Commands::ExtractWorker dispatch, the hardening tests, the stale SECURITY.md section, the nextest CI filter entry, and bincode (last production caller in the root crate).

Skipped (used on this HEAD, or explicitly out of scope)

  • restore_config_backup / write_toml_file, publish_verified_manifest, Scout prepare_configured/claim, prepare_evaluation_generation, EnrolledRemoteClient, join_generation, A1 refetch — excluded per instruction, untouched.
  • Root vendor/tree-sitter-rust wrapper crate itself — live production dependency: it backs [patch.crates-io] for tokensave-lite-treesitters.
  • src/graph/redundancy_scan.rs RedundantPair — private and heavily used by the mounted tracedecay_redundancy handler.
  • overlap_kind (runtime-core) — outside the RedundantPair family and not in the mandate; left in place.

Verification

  • cargo check --workspace --all-features — clean.
  • cargo clippy --workspace --all-targets --all-features -- -D warnings — the only failures (src/mcp/server.rs:700 expect-on-Result, src/dashboard.rs:35 items-after-test-module) reproduce identically on the unmodified base branch; no new lint debt from this diff.
  • Tests: tracedecay-hooks and tracedecay-code-extraction suites pass; tracedecay-runtime-core 650 passed with 2 pre-existing environment failures (store_runtime::resolver requires non-overlay filesystem locality, this VM is overlayfs); main-crate doctor::tests (20 passed; 2 pre-existing overlayfs failures in untouched temporal-health tests), startup_tests all pass, graph::redundancy_scan 12 passed, hooks_lsp_suite compiles after removing the extract-worker module. 7 pre-existing agent_cmd::tests failures are host-CLI-unavailable (no Codex/Kimi/OpenCode CLIs on this VM), untouched code.
  • cargo fmt --all -- --check clean for every file this PR touches (one pre-existing diff in src/daemon/project_open_owners/code_index_reads/scope_admission_tests.rs on the base branch is left alone).
  • Commits pass commitlint.

Net: −1,873 lines, +29.

Open in Web Open in Cursor 

cursoragent and others added 5 commits August 19, 2026 17:26
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2ed6197

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy marked this pull request as ready for review August 19, 2026 19:26
@ScriptedAlchemy
ScriptedAlchemy merged commit 0ccf9b7 into codex/tracedecay-total-redesign-plan Aug 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants