refactor(workflow): delete dead step-input resolution surface (A13 residue) - #520
Merged
ScriptedAlchemy merged 3 commits intoAug 19, 2026
Conversation
The A13 step executor was already deleted (5149374); its projection query surface survived with only a domain test caller. Production execution flows through Work fan-out, which records WorkflowStepOutput and never resolves WorkflowStepInput. Remove ready_steps, resolved_inputs, resolve_input, WorkflowStepInput, and the now unproducible InputsUnavailable state; re-assert dependent release via step statuses and recorded outputs. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
ScriptedAlchemy
marked this pull request as ready for review
August 19, 2026 16:27
|
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
…e-dead-workflow-step-input-surface-8712
ScriptedAlchemy
merged commit Aug 19, 2026
cf4cacd
into
codex/tracedecay-total-redesign-plan
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes out audit item A13. The
WorkflowStepExecutionService/execute_ready_stepparallel executor was already deleted on this base branch (514937401, "refactor(workflow): delete unmounted step executor"), and production workflow step execution is mounted through the Work fan-out path (workflow_run_control.rs→reconcile_workflow_fan_out, readiness fromWorkflowTopology::ready_steps). No second workflow runtime is needed or added.What remained was the executor's dead-public query surface in
tracedecay-domain, whose only caller was one domain contract test:WorkflowRunProjection::ready_steps()— production readiness comes from the runtime-core topology snapshot, never this projection query.WorkflowRunProjection::resolved_inputs()/resolve_input()and theWorkflowStepInputtype — production fan-out recordsWorkflowStepOutput/WorkflowOutputArtifactand passes fan-out inputs from the start request; nothing resolves declared inputs through the projection.WorkflowStepInputis not in the generated dashboard schema or the TypeScript SDK.WorkflowRunStateError::InputsUnavailable— only producible by the deletedresolve_input.This PR deletes all of it and rewrites the one test (
run_projection_releases_a_dependent_with_the_exact_predecessor_artifact) to assert the same dependent-release behavior through the surviving surface: step statuses (Blocked→Ready) and the predecessor's recorded canonical outputs.No version bump. No wire contract changes (verified:
WorkflowStepInputabsent fromdashboard/codegen/schemas/dashboard-contracts.schema.json,dashboard/src/contracts/generated.ts, andsdks/typescript).Verification
cargo test -p tracedecay-domain --test workflow_definition_contract— 21 passed, 0 failed.cargo check --workspace --all-features --all-targets— clean.