Skip to content

feat(hermes): add tokensave memory provider - #19

Merged
ScriptedAlchemy merged 7 commits into
masterfrom
feature/hermes-memory-provider-pr
Jun 8, 2026
Merged

feat(hermes): add tokensave memory provider#19
ScriptedAlchemy merged 7 commits into
masterfrom
feature/hermes-memory-provider-pr

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • Add a generated Hermes TokensaveMemoryProvider that exposes fact_store and fact_feedback through Tokensave's existing memory tools.
  • Configure Hermes installs with memory.provider: tokensave, including local activation guidance, named-profile installs, and --all-profiles install/uninstall support.
  • Add Hermes-focused tests for provider registration, loader-compatible schema shape, local/profile/all-profile config, and uninstall cleanup.

Test plan

  • cargo fmt
  • cargo test --test agent_test hermes
  • cargo test
  • git diff --check

@changeset-bot

changeset-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cf0562e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03533b3b04

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents/hermes.rs Outdated
@ScriptedAlchemy ScriptedAlchemy changed the title Add Tokensave Hermes memory provider feat(hermes): add tokensave memory provider Jun 8, 2026
Teach Hermes doctor checks to find tokensave installs in named profiles and project-local Hermes homes, and cover generated memory-provider discovery against Hermes-style loading.
Comment thread src/agents/hermes.rs Outdated
@ScriptedAlchemy
ScriptedAlchemy merged commit 1296585 into master Jun 8, 2026
5 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the feature/hermes-memory-provider-pr branch July 4, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant