Repository navigation
fix(pstack): load the bundled pack after test fixtures are pruned - #51
Merged
Merged
Conversation
Packaged desktop builds delete the statechart test corpus from the bundled pstack resources, but the server still copied every file in UPSTREAM.json, so materializing the pack failed with ENOENT and no /pstack:* skills loaded. The pruned directory is now one exported constant in @t3tools/pstack. pstackPackEntries excludes it from the runtime pack and the desktop build prunes exactly that directory, so a packaged source root is complete by construction. checkPack still verifies the full upstream source. Claude Opus 5.5 via T3 Code Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The unit test hardcoded the pruned directory, so a typo in PSTACK_PACKAGED_PRUNED_DIR would still pass it. It now derives the fixture paths from the constant, and a new case checks the shipped UPSTREAM.json actually carries files under that prefix so an upstream re-sync that renames the corpus cannot turn the filter into a no-op. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ScriptedAlchemy
added a commit
that referenced
this pull request
Nov 3, 2026
Keep the shared packaged-file pruning implementation from PR #51 alongside native plugin suppression. Preserve Claude's version-constrained plugin settings while suppressing native pstack whenever T3's pack is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Packaged desktop builds never load the bundled pstack skill pack. The server logs
PstackPackError: Unable to materialize the pstack packwith an ENOENT forupstream/skills/statechart/scripts/test/ConfigOracle.java, soPstackPack.catalogreturns nothing,ServerConfig.pstackSkillsis never sent, and the composer offers no/pstack:*skills even with the setting enabled.The build step
prunePackagedPstackTestFixturesdeletesskills/statechart/scripts/test/from the packaged resources, butpstackPackEntriesstill copies every file inUPSTREAM.json, including those 376 fixtures. Dev checkouts have the files, so only packaged builds break.Fix
Define the pruned directory once as
PSTACK_PACKAGED_PRUNED_DIRin@t3tools/pstack.isRuntimePackFileskips paths under it, and the build prune step derives its target from the same constant, so the two can no longer drift.Tests: a
check.test.tscase seals a fixture pack, deletes the test corpus, and asserts every remaining entry exists on disk. The build-artifact Windows payload test now also asserts everypstackPackEntriessource path survives pruning. Both failed before the fix.Implemented by Claude Opus 5.5, reviewed by Grok 4.6 and DeepSeek V4.1 Flash, orchestrated by Claude Fable 5.1 via T3 Code.
🤖 Generated with Claude Code