Repository navigation
fix(acp): keep npm shim installs in the managed prefix - #45
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP Registry reported a successful Copilot install and then failed to resolve its command when npm was a Volta shim. Volta intercepted global installs despite
npm_config_prefix, leaving T3’s managed directory empty.Pass the managed directory explicitly with
npm install --global --prefixso installation and discovery agree. Extend the existing install test with a shim fixture that ignores environment-only prefixes.Validation: the regression failed with the reported error before the fix; all 34 registry tests pass afterward.
vp run check:changedpasses (35 affected tests, formatting, lint, knip, affected typechecks). A real Volta-wrapped npm installed@github/copilot@1.0.105into a temporary explicit prefix and its command returnedGitHub Copilot CLI 1.0.105; temporary files were removed.Model: gpt-6.1-sol. Harness: Codex through T3 Code.