Skip to content

Fix an infinite loop that can occur in some builds #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaceCear wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −2
Open

Fix an infinite loop that can occur in some builds #256

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a0343b
Fix an infinite loop that can occur in some builds
JaceCear Apr 15, 2026
014cdb0
Simplify in-vblank check
JaceCear Apr 16, 2026
ac0e507
More thorough explanation of the Vblank busy loop
JaceCear Apr 16, 2026
dca8262
Merge branch 'main' into ogl_inf_loop_fix
JaceCear Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,8 +609,10 @@ void EngineMainLoop(void)
}
#endif

// Wait for vblank to finish
while (REG_DISPSTAT & DISPSTAT_VBLANK)
// NOTE: If other platforms do V-Sync asynchronously, we may need to incorporate this wait.
//
// Wait for vblank to finish, we only compute the frame once the new frame started.
while (PLATFORM_GBA && (REG_DISPSTAT & DISPSTAT_VBLANK))
;
};
}
Expand Down
Loading