Repository navigation
Use current! instead of bindings::get_current() in Task::pid_in_current_ns #1047
Description
The function Task::pid_in_current_ns in rust/kernel/task.rs uses bindings::get_current(). But there exists a safe abstraction for the raw binding: the current! macro. Change the implementation to use that abstraction instead.
You might also have to add a function on Task to get access to the raw C pointer.
This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes, to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and so on. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.
Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel.
Activity
antonio-hickey commentedon Jan 2, 2024
I'm not finding the function
Task::pid_in_current_nsinrust/kernel/task.rs.I see the use of
bindings::get_current()incurrent()is this where we want to use the safe macro instead? @y86-devEDIT: I see now, it's in the
rust-devbranch.antonio-hickey commentedon Jan 3, 2024
What's the reason I would or would not have to add a function to grab the raw C pointer? Any further detail on this would be appreciated, thanks.
jsat97 commentedon Oct 24, 2024
If this is still available, may I work on it ?
antonio-hickey commentedon Oct 24, 2024
@jsat97
I've already sent my patches
tamird commentedon Feb 14, 2025
I believe the code this issue refers to never made it upstream. This is obsolete.
BennoLossin commentedon Feb 15, 2025
you're correct, thanks for spotting this 👍
The code was introduced in 8ad1a41 and used
pid_in_current_nsfrom the start.