This repository was archived by the owner on Apr 15, 2026. It is now read-only.
Merged
Conversation
Collaborator
Author
|
@tombh I thought I had already added you as a maintainer, but I guess not. I've sent you an invite. Once you've accepted I can request your review here :) |
Collaborator
Author
|
...so maybe these changes are extraneous? |
Collaborator
Author
|
Ah, yes, I see your branch has bumped these as well, though not as far as my changes. |
Collaborator
|
Just a quick reply to say I got the invitation, thanks. And that I'm trying to remember how we support this |
Collaborator
Author
|
I'll rebase and run with the new CI improvements 👍 |
tombh
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error where
spirv-builder-clifails to compile because of unresolved dependencies onbytemuckanditoa.Here's my output when trying to compile
renderling, which targetsrust-gpu6e2c84d: