[FIX] : handle null room in contextual bar overflow interactions#67
Merged
iam-vipin merged 1 commit intoRocketChat:mainfrom Mar 21, 2026
Merged
Conversation
Contributor
Author
|
hey @iam-vipin friendly bump on this one! Fixes the broken contextual bar interactions.a pretty straightforward change but puts the models in contextual bar to life again!Would appreciate a review when you get a chance |
This was referenced Mar 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #66
Acceptance Criteria fulfillment
Cause!
roomasnullThe check
room === undefinedonly catchesundefined, notnullnull, leading to "Cannot read properties of null (reading 'id')" error when trying to open modalsProposed changes
Screencast.from.2026-02-12.02-16-40.webm
Changed from strict equality check (
=== undefined) to truthy check (!room)!roomevaluates totruefor bothnullANDundefinedFurther comments
well this bug was breaking the working of contextual bar... given the severity i opened the pr upfront kindly do review the changes