Skip to content

[FIX] : handle null room in contextual bar overflow interactions#67

Merged
iam-vipin merged 1 commit intoRocketChat:mainfrom
not-meet:fix/contextual-bar-overflow-action
Mar 21, 2026
Merged

[FIX] : handle null room in contextual bar overflow interactions#67
iam-vipin merged 1 commit intoRocketChat:mainfrom
not-meet:fix/contextual-bar-overflow-action

Conversation

@not-meet
Copy link
Copy Markdown
Contributor

Issue #66

Acceptance Criteria fulfillment

  • Contextual bar overflow interactions should open the respective modals

Cause!

  • Contextual bar interactions provide room as null
    The check room === undefined only catches undefined, not null
  • This caused the room to remain null, leading to "Cannot read properties of null (reading 'id')" error when trying to open modals

Proposed changes

Screencast.from.2026-02-12.02-16-40.webm

Changed from strict equality check (=== undefined) to truthy check (!room)
!room evaluates to true for both null AND undefined

Further comments

well this bug was breaking the working of contextual bar... given the severity i opened the pr upfront kindly do review the changes

@not-meet
Copy link
Copy Markdown
Contributor Author

hey @iam-vipin friendly bump on this one! Fixes the broken contextual bar interactions.a pretty straightforward change but puts the models in contextual bar to life again!Would appreciate a review when you get a chance

@iam-vipin iam-vipin merged commit 9eaa4ef into RocketChat:main Mar 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants