feat: Default replies for new app users#56
Open
priyanshuharshbodhi1 wants to merge 3 commits intoRocketChat:mainfrom
Open
feat: Default replies for new app users#56priyanshuharshbodhi1 wants to merge 3 commits intoRocketChat:mainfrom
priyanshuharshbodhi1 wants to merge 3 commits intoRocketChat:mainfrom
Conversation
- ensures that both admin and users gets it - tried to make it most optimised(not sure)
|
|
Author
|
Hey @VipinDevelops , |
iam-vipin
requested changes
Apr 11, 2025
QuickRepliesApp.ts
Outdated
| /** | ||
| * Get the association records for tracking user initialization status | ||
| */ | ||
| private getInitAssociations(userId: string): RocketChatAssociationRecord[] { |
Collaborator
There was a problem hiding this comment.
do we need this methods ?
| * Initialize default quick replies for a user who hasn't used the app before | ||
|
|
||
| */ | ||
| public async initializeDefaultRepliesForUser( |
Collaborator
There was a problem hiding this comment.
To much login in the root of the app can we define thing outside and use here ?
Author
|
I’ve pushed the requested changes. Let me know if anything else is needed... DEMO VIDEO: (Whenever a user installs the app, user will have default replies in the list. Screencast.from.2025-04-23.20-03-38.webm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
closes #26
Acceptance Criteria fulfillment
Further comments
Not sure if it is the most optimal and correct solution to the requested changes in PR #38. Please confirm it.