Sdr service eventstream#2749
Merged
Merged
Conversation
abdulazizali77
self-requested a review
February 8, 2018 06:58
Contributor
|
@agafox can you rebase and resolve conflicts? |
abdulazizali77
force-pushed
the
sdr-service-eventstream
branch
from
February 9, 2018 04:32
ee621a8 to
885a05c
Compare
abdulazizali77
left a comment
abdulazizali77
left a comment
Contributor
There was a problem hiding this comment.
@agafox, some preliminary thoughts
- For any class implementing
onTransitionEnd, would it make sense to publish thewas,isstates and theeventwhich triggered the transition?
nits:
- later, can we squash the redundant commit-revert commits?
abdulazizali77
force-pushed
the
sdr-service-eventstream
branch
from
February 18, 2018 19:18
885a05c to
a06808b
Compare
added 7 commits
March 2, 2018 12:40
abdulazizali77
force-pushed
the
sdr-service-eventstream
branch
from
March 2, 2018 04:44
a06808b to
31ff072
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.