Conversation
comnik
reviewed
Apr 15, 2026
comnik
reviewed
Apr 15, 2026
Comment on lines
+8
to
+9
| - FIELD_NO_DELETE | ||
| - MESSAGE_NO_DELETE No newline at end of file |
Collaborator
There was a problem hiding this comment.
Hm these should not be generic exceptions, I'm not sure how that slipped in. We should have to explicitly override the compatibility check when we remove messages or delete fields. In cases like this one it is ok to do so.
Contributor
Author
There was a problem hiding this comment.
I scoped it down to the file. Is that OK?
Collaborator
There was a problem hiding this comment.
For now it is, I took a note to look into this more.
comnik
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.