Skip to content

more configure tweaks#3974

Merged
mattdowle merged 2 commits into
masterfrom
configure_2
Oct 17, 2019
Merged

more configure tweaks#3974
mattdowle merged 2 commits into
masterfrom
configure_2

Conversation

@mattdowle
Copy link
Copy Markdown
Member

More follow up to #3964
This time not Solaris but something odd on CRAN's macOS.


From Kurt :

For the prev submission, Prof Ripley found the following:

This version does not install for me on macOS:

pkg-config did not detect zlib is installed. Please install it:
* deb: zlib1g-dev (Debian, Ubuntu, ...)
* rpm: zlib-devel (Fedora, EPEL, ...)
* brew: zlib (OSX)
ERROR: configuration failed for package ‘data.table’

macOS does not have pkg-config, nor does it supply .pc files for its
system software (SU has packaged some, but not zlib nor for current
macOS).  And a pkg-config-only test is not portable for other platforms.

Can you pls fix accordingly?

Best
-k


From Matt :

Thanks, Kurt and Prof Ripley.

I don't assume that pkg-config is installed, but it appears then that it is installed on that macOS box (as R-exts note 25 says) but, oddly, pkg-config is claiming zlib is not installed when we know it is (since current CRAN error with recent 1.12.4 on macOS is runtime error long after compilation, which stands to reason since zlib is required by R itself). This all works fine on Travis macOS so it is not macOS per se.

However, I can see a fix I can make for this situation; i.e., pkg-config being installed but not returning an accurate result. I'll fix and resubmit.

I'm hoping this means the previous attempt works now on Solaris then? I can see Rrof Ripley added 'checkbashisms' to R-exts note 24 as I suggested (so he received that email), but I didn't hear back from him after that 2nd Solaris attempt. (I didn't receive the reply you've quoted from him about macOS.)

Best, Matt

@mattdowle mattdowle added this to the 1.12.5 milestone Oct 17, 2019
@mattdowle mattdowle merged commit d7feb91 into master Oct 17, 2019
@mattdowle mattdowle deleted the configure_2 branch October 17, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant