more configure tweaks#3974
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More follow up to #3964
This time not Solaris but something odd on CRAN's macOS.
From Kurt :
For the prev submission, Prof Ripley found the following:
Can you pls fix accordingly?
Best
-k
From Matt :
Thanks, Kurt and Prof Ripley.
I don't assume that pkg-config is installed, but it appears then that it is installed on that macOS box (as R-exts note 25 says) but, oddly, pkg-config is claiming zlib is not installed when we know it is (since current CRAN error with recent 1.12.4 on macOS is runtime error long after compilation, which stands to reason since zlib is required by R itself). This all works fine on Travis macOS so it is not macOS per se.
However, I can see a fix I can make for this situation; i.e., pkg-config being installed but not returning an accurate result. I'll fix and resubmit.
I'm hoping this means the previous attempt works now on Solaris then? I can see Rrof Ripley added 'checkbashisms' to R-exts note 24 as I suggested (so he received that email), but I didn't hear back from him after that 2nd Solaris attempt. (I didn't receive the reply you've quoted from him about macOS.)
Best, Matt