Remove deprecated std::iterator#193
Merged
Merged
Conversation
kevinushey
approved these changes
Jan 31, 2023
Contributor
kevinushey
left a comment
kevinushey
left a comment
There was a problem hiding this comment.
LGTM; thanks for putting this together!
Do we need to prepare a CRAN release of RcppParallel with this patch?
Member
Author
|
I don't think this is a problem yet, and when it is, switching to a more recent version of tbb will be needed anyway. So I'd say no rush. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves away from
std::iterator, and thus the warning inRMatrix.h. #121 is needed to remove warnings in bundled tbb.Closes #192.