Skip to content

fix: Fix bug that prevented editing workspace comments on Firefox. #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 3 commits into from
Feb 20, 2025
Merged

fix: Fix bug that prevented editing workspace comments on Firefox. #8779

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
748bdbd
fix: Fix bug that prevented editing workspace comments on Firefox.
gonfunko Feb 18, 2025
d39d01e
chore: Add a docstring for getTextArea().
gonfunko Feb 18, 2025
9d8a39e
refactor: Use isTargetInput() instead of comparing to comment textarea.
gonfunko Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions core/comments/rendered_workspace_comment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,14 @@ export class RenderedWorkspaceComment
private startGesture(e: PointerEvent) {
const gesture = this.workspace.getGesture(e);
if (gesture) {
gesture.handleCommentStart(e, this);
this.workspace.getLayerManager()?.append(this, layers.BLOCK);
if (browserEvents.isTargetInput(e)) {
// If the text area was the focus, don't allow this event to bubble up
// and steal focus away from the editor/comment.
e.stopPropagation();
} else {
gesture.handleCommentStart(e, this);
Copy link
Copy Markdown
Collaborator

@rachel-fenichel rachel-fenichel Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next question: why is this not already fixed by the other uses of isTargetInput in inject.ts and gesture.ts?

Copy link
Copy Markdown
Contributor Author

@gonfunko gonfunko Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleCommentStart() doesn't ever call doStart(), where isTargetInput() is checked; handleWsStart does, but by the time that's called the event has already bubbled up to the workspace and stolen focus away from the textarea, so it's too late. Likewise, inject.ts only checks it for keydown and contextmenu events, not clicks.

this.workspace.getLayerManager()?.append(this, layers.BLOCK);
}
common.setSelected(this);
}
}
Expand Down