fix: Fix the browser tests.#8735
Merged
Merged
Conversation
rachel-fenichel
approved these changes
Jan 16, 2025
1 task
gonfunko
added a commit
that referenced
this pull request
Jan 16, 2025
(cherry picked from commit a86ba15)
RoboErikG
pushed a commit
to RoboErikG/blockly
that referenced
this pull request
Feb 19, 2025
RoboErikG
pushed a commit
to RoboErikG/blockly
that referenced
this pull request
Feb 19, 2025
(cherry picked from commit a86ba15)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
This PR fixes various failures in the WebDriver interactive browser tests, which have been neglected for some time. This PR also includes a fix for an actual bug caught by the tests where scrolling menu items into view could scroll the page itself in addition to just the menu.