fix: Listen for keyboard shortcuts when the widget or dropdown divs have focus.#8731
Merged
Merged
Conversation
rachel-fenichel
approved these changes
Jan 14, 2025
Collaborator
rachel-fenichel
left a comment
rachel-fenichel
left a comment
There was a problem hiding this comment.
LGTM. I took a look at onKeyDown to confirm that it handles cases where there are multiple workspaces; I think it does, because it calls getMainWorkspace and should get the mostly recently modified/interacted with workspace.
Contributor
|
Thank you for the quick fix! Could you all let us know when this will make its way into a new release? Code.org will be hanging out on 11.1.1 in the meantime. |
Contributor
Author
|
Sure thing! This is included in the just-released 11.2.1. |
RoboErikG
pushed a commit
to RoboErikG/blockly
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8725
Proposed Changes
This PR adds keydown listeners for the widget and dropdown divs and runs those events through the shortcut infrastructure. This allows keyboard shortcuts (e.g. esc, delete, copy/paste) to operate when a menu/dropdown is focused.