fix(tests): generator tests on linux#6588
Merged
rachel-fenichel merged 1 commit intoOct 28, 2022
Merged
Conversation
gonfunko
approved these changes
Oct 28, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes an issue where the generator tests fail on Linux with
Proposed Changes
Remove trailing slashes from calls to
rimraf.Behavior Before Change
Crashes on linux
Behavior After Change
Tests run and don't crash.
Reason for Changes
Rimraf didn't like the trailing slash, which is surprising to me.
Additional Information
Caused by #6431 so we'll need to verify it still works on windows after this fix.