Skip to content

[components][dfs]separate dfs fs data structure ops#9205

Merged
BernardXiong merged 1 commit intoRT-Thread:masterfrom
zmshahaha:fs
Jan 14, 2025
Merged

[components][dfs]separate dfs fs data structure ops#9205
BernardXiong merged 1 commit intoRT-Thread:masterfrom
zmshahaha:fs

Conversation

@zmshahaha
Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

抽象非基于硬盘的文件系统(如tmpfs,devtmpfs等)的文件组织,独立成API使用
[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zmshahaha zmshahaha force-pushed the fs branch 2 times, most recently from eb47235 to 722c86c Compare July 17, 2024 09:49
@zmshahaha zmshahaha marked this pull request as ready for review July 18, 2024 06:03
@zmshahaha zmshahaha requested a review from BernardXiong as a code owner July 18, 2024 06:03
{
#endif

struct dfs_vfs_node
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dfs = vfs,这样就变得重复了

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个目的是抽出一个通用的虚拟文件系统管理层。逻辑是很多调试、系统管理用的文件系统,devfs、procfs、sysfs、debugfs 等本质都是基于 tmpfs 衍生出来的,但现在 devfs、tmpfs、procfs 都有单独的文件管理实现。这不利于维护。所以希望单独抽出一个层次的抽象,专注于虚拟文件系统的文件与目录管理。

命名确实可以再讨论一下。比如 dfs_libvfs 这样是否可以。

Copy link
Copy Markdown
Contributor Author

@zmshahaha zmshahaha Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那我改libvfs吗?

@@ -111,15 +110,13 @@ static int _get_subdir(const char *path, char *name)
#if 0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块代码本身也有些问题,不应该有#if 0的代码的。这次提交也一起拿掉吧

@polarvid polarvid added the RT-Smart RT-Thread Smart related PR or issues label Jul 26, 2024
@BernardXiong BernardXiong merged commit 0ae537e into RT-Thread:master Jan 14, 2025
1078249029 pushed a commit to 1078249029/rt-thread that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: dfsv2 RT-Smart RT-Thread Smart related PR or issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants