Skip to content

Fix JAX sdist version pinning#533

Merged
ipanfilo merged 1 commit into
devfrom
ipanfilo/jax_sdist_verion_fix
Apr 9, 2026
Merged

Fix JAX sdist version pinning#533
ipanfilo merged 1 commit into
devfrom
ipanfilo/jax_sdist_verion_fix

Conversation

@ipanfilo
Copy link
Copy Markdown
Collaborator

@ipanfilo ipanfilo commented Apr 9, 2026

Description

Do not pip specific JAX version when create sdist
Fixes https://amd-hub.atlassian.net/browse/AITRANSENG-43

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Check for NVTE_RELEASE_BUILD when pipping to specific JAX version

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ipanfilo ipanfilo added the ci-level 1 CI test level 1 label Apr 9, 2026
Copy link
Copy Markdown
Collaborator

@wangye805 wangye805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ipanfilo ipanfilo merged commit 0981157 into dev Apr 9, 2026
3 checks passed
@ipanfilo ipanfilo deleted the ipanfilo/jax_sdist_verion_fix branch April 9, 2026 21:08
@ipanfilo ipanfilo mentioned this pull request Apr 9, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-level 1 CI test level 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants