Skip to content

FIX Wheel building#512

Closed
Micky774 wants to merge 1 commit into
devfrom
zain/wheel-build-fix
Closed

FIX Wheel building#512
Micky774 wants to merge 1 commit into
devfrom
zain/wheel-build-fix

Conversation

@Micky774
Copy link
Copy Markdown
Contributor

Description

During the testing of IFU 2.12 I noticed a couple of issues which made it so that following our documented wheel building process would result in errors and failures. This PR addresses two of such issues (with the final being an AITER issue that is being worked on separately).

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Installs wheel after torch since torch downgrades setuptools which otherwise vendors wheel
  • Adds an explicit ROCM_PATH environment variable to ensure that ROCm is properly found during the build

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Micky774 Micky774 mentioned this pull request Mar 30, 2026
13 tasks
Copy link
Copy Markdown
Collaborator

@ipanfilo ipanfilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is covered by #511

@Micky774 Micky774 added the ci-level 1 CI test level 1 label Mar 30, 2026
@Micky774 Micky774 closed this Mar 30, 2026
@Micky774 Micky774 deleted the zain/wheel-build-fix branch March 30, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-level 1 CI test level 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants