Skip to content

Implement equidistant spacing for mobile navigation icons #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngoiyaeric merged 1 commit into from
Aug 7, 2026
Merged

Implement equidistant spacing for mobile navigation icons #758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,10 @@

.mobile-icons-bar-content {
display: flex;
gap: 16px;
padding: 0 10px;
min-width: max-content;
justify-content: flex-start;
width: 100%;
min-width: 100%;
padding: 0 12px;
justify-content: space-between;
Comment on lines +152 to +155

@qodo-code-review qodo-code-review Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Spacing disappears on overflow 🐞 Bug ≡ Correctness

By removing the fixed gap and relying on justify-content: space-between, the bar no longer
guarantees any minimum spacing between icons; when there is no positive free space, the between-item
spacing becomes 0px. Because children are explicitly prevented from shrinking, narrower viewports or
additional controls can cause icons/buttons to sit flush against each other.
Agent Prompt 
## Issue description
`justify-content: space-between` only distributes *positive* remaining free space. This PR removed the fixed `gap`, so when the toolbar has little/no free space, the inter-item spacing can collapse to 0px. Since the toolbar’s children are configured not to shrink, this situation is more likely when the number of controls increases or on narrower viewports.

## Issue Context
- The toolbar is placed inside a horizontally scrollable container (`.mobile-icons-bar { overflow-x: auto; }`), and each child is `flex-shrink: 0`, so the toolbar can overflow rather than compress.
- With no `gap`, overflow/near-overflow results in no guaranteed spacing between adjacent controls.

## Fix Focus Areas
- app/globals.css[150-160]

### Suggested change
Keep `justify-content: space-between` (if desired) but reintroduce a minimum spacing, e.g.:
- Add `gap: 12px;` (or restore 16px) to `.mobile-icons-bar-content`.

Alternative (if you truly want equal edge+internal spacing):
- Use `justify-content: space-evenly` and remove/adjust padding accordingly.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

}

.mobile-icons-bar-content > * {
Expand Down