Handle Yjs awareness on the widget comm#40
Conversation
|
Maybe pin pytest=8 for now so that the CI passes |
|
I think it requires rethinking the async fixtures, I can look at it. |
da62498 to
5e14812
Compare
|
Thanks @gjmooney. We'll need a test for the new functionality. |
b0c950a to
a295d55
Compare
davidbrochart
left a comment
There was a problem hiding this comment.
I think that there is too much mocking in the tests, in the end they don't test much.
Could you try and test more with less mocking?
@gjmooney Don't worry if you cannot reach full coverage. I'm fine with no test and explicit |
de328d0 to
2d86227
Compare
|
There is something I don't understand: your |
For now setting the awareness from the kernel has not been evoked on our side. I wonder if that is something we want to do? |
|
Isn't test_remote_manager_applies_awareness_messages doing just that? I suggest to remove it then. |
062974a to
61782e4
Compare
ae6cfb2 to
121e201
Compare
|
Just a note for the future: could you fork the repo and make a PR from there instead of creating a branch here? |
This PR wires up
pycrdtAwareness, so the kernel can consumeYMessageType.AWARENESSframes.CommProvidercreates an Awareness(ydoc) alongside sync/update handling. Inbound messages whose first byte isYMessageType.AWARENESSare decoded withread_messageand applied withapply_awareness_update.CommWidgetexposesawareness, pluson_awareness_change/unobserve_awarenessas thin wrappers overAwareness.observe/unobservefor notebooks and library code.