Calling CSharp releases the GIL#7970
Merged
Martin-Molinero merged 1 commit intoApr 23, 2024
Merged
Conversation
0782f94 to
d9eb31b
Compare
- Make sure calling CSharp methods, fields, properties releases the GIL, this was not hapenning for fiels & properties, adding unit test reproducing the issue
d9eb31b to
46e3e89
Compare
jaredbroad
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See QuantConnect/pythonnet#91
Related Issue
Closes #7925
Motivation and Context
Deadlock
Requires Documentation Change
N/A
How Has This Been Tested?
Unit test reproducing issue
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>