Repository navigation
Add shared point-source likelihood breakdown - #293
Merged
Merged
Conversation
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the shared point-source image-plane likelihood breakdown required before the CPU and A100 optimization campaigns. The instrument opens all eight PointSolver refinements into cumulative ray-trace, containment, selection, neighbourhood, and up-sampling boundaries while retaining the fused production likelihood as the authoritative runtime.
The committed CPU fp64 baseline measures the solved likelihood at 62.687 ms/call and the separately labelled free-centre control at 74.346 ms/call. Eager/JIT likelihoods agree,
vmap(2)agrees in both lanes, the gradient is finite, and four finite model positions survive filtering.Scripts Changed
scripts/point_source/likelihood_breakdown/image_plane.py— adds the device-aware shared breakdown, source/library provenance, JIT-phase timing, numerical controls, and two-panel absolute-prefix/signed-difference plot.results/breakdown/point_source/image_plane_local_cpu_fp64.{json,png}— records the first canonical CPU fp64 reference row.results/notes/point_source_shared_likelihood_breakdown.md— explains the measurement contract, fusion caveat, CPU result, and A100 handoff.README.mdandscripts/misc/likelihood_breakdown/README.md— add the generatedpoint_source/image_planeresult row.Test Plan
3052443(626 s).ruff check .ruff format --check .python scripts/misc/tooling/build_readme.py --checkgit diff --checkHeart readiness was
STALEwith no RED/YELLOW reasons:release validation incomplete: no rehearsal for current source. This permits a development PR and remains a release blocker.Closes #291.
Generated by the PyAutoLabs agent workflow.