Repository navigation
fix(tests): assert dashboard.md href, not the markdown-link label - #293
Merged
Merged
Conversation
PyAutoBrain#499 restyles the "markdown version" anchor into an icon in the shared board theme, so test_html_is_self_contained's literal-anchor assertion fails on every Heart run since 2026-10-07 18:52Z. Assert the href survives the theme pass instead of pinning Brain's old markup. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_dashboard.py::test_html_is_self_containedpinned the literal<a href="dashboard.md">markdown version</a>anchor. PyAutoBrain#499 (merged 2026-10-07) renders that label as an icon in the shared board theme, so Heart's test has failed on every run since (e.g. PyAutoHeart#292 run 37683297574, 1 failed / 1228 passed).dashboard.mdhref survives the theme pass instead of Brain's old markup. Heart-side relaxation matches the theme's intent and is the smaller change.Mind bug prompt:
draft/bug/pyautoheart/dashboard_markdown_link_test_broken_by_brain_499.md(epic search-extensibility B1 close-out; unblocks #292).Test plan
pytest tests/test_dashboard.pylocally against PyAutoBrain main 1100c20: 129 passed🤖 Generated with Claude Code