Repository navigation
test: pin DelaunayNN routing to the numba likelihood paths (#623 phase 2) - #625
Merged
Merged
Conversation
Phase 2 of #623. DelaunayNN mappers already route to InversionInterferometerSparseNumba and InversionImagingSparseNumba on the Aris interferometer and HST-scale imaging setups, and NaN Sibson weights already give NaN evidence on every route, so no routing change is needed. Add routing, numba-vs-reference parity and NaN-weight tests for DelaunayNN, and document the NaN contract on the interferometer gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of #623 (stacked on #624 — merge #624 first). Audits whether DelaunayNN mappers (Sibson rows up to 32 wide, NaN weights on overflow/degenerate) reach the numba likelihood paths and agree with the reference routes. Result: no routing or gate change needed — every measured case already takes the numba class, and NaN weights already give NaN evidence on every route. This PR pins that with tests and documents it.
Steady
log_likelihood_function, threads=1 (load 3–5, noisy): imaging sub 2 1030v Delaunay 0.31–0.38 s / NN 0.32 s; 1530v 0.34 / 0.48 s; sub 4 1030v 0.29 / 0.78 s. Interferometer (from #624): 0.41 / 0.57 s @1405, 8.2 / 12.1 s @5526. Imaging sub-4 gap isunique_mappings+adaptive_pixel_signals_fromiterating 32-wide padded rows → filed as Mind follow-updraft/feature/autoarray/delaunaynn_wide_row_imaging_overhead.md.NaN weights: forced Sibson neighbour overflow → curvature matrix and log-evidence NaN on mapping, FFT-sparse and numba-sparse interferometer routes and mapping / numba imaging routes, standard and positive-only solvers; nothing raises. A routing guard would give the same NaN slower, so none added.
API Changes
None — internal changes only (docstrings + tests).
See full details below.
Test Plan
InversionInterferometerSparseNumbaat default gate; numba vs FFT parity on variable-width rows (rel 1e-10); NaN weights → NaN evidence on numba / FFT / mapping with factory still choosing numbaInversionImagingSparseNumba, parity vsInversionImagingMapping; NaN-weight paritynan_to_numinkernel_inputs_from/data_slim_to_pixelization_unique_frommakes both NaN tests failtest_autoarray/full: 2031 passed, 4 xfailed; emulated nojax on changed files: 37 passedsize == 0keeps its NaNs in padding, so routes would agree on a finite (wrong) evidence — to be tracked separatelyFull API Changes (for automation & release notes)
Changed Behaviour
factory._use_interferometer_numbaandInversionInterferometerSparseNumba._check_preconditionsnow state the NaN-weight contract.Heart RED override (development only)
Same live-human authorisation as #624 / #623 ("I override, tests will be handled once the epic refactor elsewhere is sorted"), re-confirmed by "go" for phase 2 in the same session. Commit, push and PR-open only — merge needs a separate human
/prmwith required checks green; does not claim to fix Heart. Current readinessstale("release validation incomplete: no rehearsal for current source"); feed RED reasons verbatim in #624. Branch gates passed: tests, nojax emulation, independent review (above).Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code