40-validation-early-stop#73
Merged
Merged
Conversation
Nic-Ma
reviewed
Feb 12, 2020
Nic-Ma
reviewed
Feb 12, 2020
Contributor
|
@madil90 could you update |
Nic-Ma
approved these changes
Feb 13, 2020
Contributor
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me for current MVP version.
We may need to refactor utils part in later sprints.
And define unified format for model output, then we can use the util function "stopping_fn_from_loss".
Thanks.
Nic-Ma
approved these changes
Feb 13, 2020
Contributor
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me for current MVP version.
We may need to refactor utils part in later sprints.
And define unified format for model output, then we can use the util function "stopping_fn_from_loss".
Thanks.
db5d9b2 to
4175142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40 fixes #8
Description
Added example for model validation every step with metric logging. Added util functions for early stopping.
Status
Ready
Types of changes
with this PR, running the training program gives: