5991 Support more spatial transforms to use lazy resampling - #6080
Merged
wyli merged 65 commits intoMar 14, 2023
Merged
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
for more information, see https://pre-commit.ci
yiheng-wang-nv
changed the title
yiheng-wang-nv
commented
Feb 28, 2023
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv
commented
Mar 6, 2023
7 tasks
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
…hub.com:yiheng-wang-nv/MONAI into 5991-add-spatial-transforms-for-lazy-resampling Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
…ps://github.com/yiheng-wang-nv/MONAI into 5991-add-spatial-transforms-for-lazy-resampling
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
wyli
force-pushed
the
5991-add-spatial-transforms-for-lazy-resampling
branch
from
March 13, 2023 17:53
715b042 to
3fb2d76
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Nic-Ma
reviewed
Mar 14, 2023
| mode: str = GridSampleMode.BILINEAR, | ||
| padding_mode: str = GridSamplePadMode.ZEROS, | ||
| align_corners: bool = False, | ||
| align_corners: bool = True, |
Contributor
There was a problem hiding this comment.
May I know why change the default value of align_corners?
Thanks.
Contributor
There was a problem hiding this comment.
there's a bug in the current dev implementation, the default behaviour of AffineTransform() is actually the same as AffineTransform(align_corners=True)
Contributor
There was a problem hiding this comment.
Will this change break any existing user programs? Or do we need to update any tutorial or bundle?
And I think better to use deprecated_arg_default? https://github.com/Project-MONAI/MONAI/blob/dev/monai/utils/deprecate_utils.py#L230?
CC @yiheng-wang-nv
Thanks.
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
5991-add-spatial-transforms-for-lazy-resampling
branch
from
March 14, 2023 16:18
7215749 to
efdc6c0
Compare
Contributor
|
/build |
…rms-for-lazy-resampling Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
5991-add-spatial-transforms-for-lazy-resampling
branch
from
March 14, 2023 16:27
efdc6c0 to
589af32
Compare
Contributor
|
/build |
…nsforms-for-lazy-resampling Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
wyli
enabled auto-merge (squash)
March 14, 2023 17:51
Contributor
|
/build |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5991 .
Description
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.