add crop transforms with unit tests for lazy resampling - #6068
Merged
Conversation
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
KumoLiu
commented
Feb 27, 2023
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
KumoLiu
commented
Feb 27, 2023
Signed-off-by: KumoLiu <yunl@nvidia.com>
Contributor
Author
|
Just set this PR to be ready for review. And will create another pr for |
KumoLiu
marked this pull request as ready for review
February 27, 2023 16:34
KumoLiu
changed the title
wyli
approved these changes
Feb 27, 2023
Nic-Ma
approved these changes
Feb 28, 2023
Nic-Ma
left a comment
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good to me, put some minor coments inline.
Thanks.
Contributor
|
/build |
wyli
enabled auto-merge (squash)
February 28, 2023 09:40
wyli
disabled auto-merge
February 28, 2023 09:59
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5991 .
Description
This PR adds the crop transforms from #5860 relate to lazy resampling, and it belongs to the second part mentioned in #5991
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.