5991 add utility enhancements for lazy resampling - #6017
Merged
wyli merged 5 commits intoFeb 17, 2023
Merged
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
for more information, see https://pre-commit.ci
yiheng-wang-nv
commented
Feb 17, 2023
yiheng-wang-nv
commented
Feb 17, 2023
wyli
reviewed
Feb 17, 2023
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv
commented
Feb 17, 2023
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv
marked this pull request as ready for review
February 17, 2023 11:09
yiheng-wang-nv
changed the title
wyli
approved these changes
Feb 17, 2023
Contributor
|
/build |
wyli
enabled auto-merge (squash)
February 17, 2023 11:35
11 tasks
yiheng-wang-nv
deleted the
5991-add-utility-enhancements-for-lazy-resampling
branch
February 17, 2023 12:36
Nic-Ma
reviewed
Feb 20, 2023
| resampler = monai.transforms.SpatialResample(**init_kwargs) | ||
| # resampler.lazy_evaluation = False | ||
| with resampler.trace_transform(False): # don't track this transform in `data` | ||
| # resampler.lazy_evaluation = False # resampler is a lazytransform |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Hi @Nic-Ma , .lazy_evaluation requires the transform extends LazyTransform, now the class in dev branch does not have related code (see: https://github.com/Project-MONAI/MONAI/pull/5860/files#diff-3a1b9fb96f9cde878a33605fcbd39cf1af51a79c285fe662d80a00f0c43e2d5fL114) This line will be uncommented after related changes are added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5991 .
Description
This PR adds the minor utility enhancements from #5860 relate to lazy resampling, and it belongs to the first part mentioned in #5991
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.