3922 Make UNETR support torchscript#3923
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Mar 11, 2022
Merged
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv
requested review from
ahatamiz and
wyli
and removed request for
ahatamiz
Contributor
|
/build |
Contributor
|
@yiheng-wang-nv Thanks for the quick action regarding Torchscript support. Everything looks good to me. @wyli I think this can be merged without any issues. |
ahatamiz
approved these changes
Mar 11, 2022
Contributor
Author
|
There is a mypy error, but it seems not relate to this PR ( https://github.com/Project-MONAI/MONAI/runs/5506206637?check_suite_focus=true#step:7:466) I checked with the dev branch and found the same error locally. |
Contributor
yes this is from torch update, I had a fix in #3832. I'll merge this PR soon. |
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang vennw@nvidia.com
Fixes #3922 .
Description
This PR makes UNETR support torchscript, and it also changes some unit test typos.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.