With a fix in PSReadLine, we don't have to return a "null" key press#1758
Merged
Conversation
Member
Author
|
This requires that the PR in PSReadLine is merged an a new release pushed out, staying in draft until then. |
andyleejordan
force-pushed
the
andschwa/readkey-race
branch
2 times, most recently
from
April 15, 2022 19:03
1f1220c to
9290afd
Compare
Member
Author
|
Ah ha! @SeeminglyScience now that |
andyleejordan
force-pushed
the
andschwa/readkey-race
branch
from
April 19, 2022 00:29
34f9441 to
492321b
Compare
3 tasks
Member
Author
|
The second commit is more of an aesthetic cleanup, it's not necessary to get that working perfectly to merge this, but we do need a patch release of PSReadLine, and I'd like to get this into the next RC. |
andyleejordan
force-pushed
the
andschwa/readkey-race
branch
2 times, most recently
from
April 20, 2022 18:18
58a6db5 to
7d21d59
Compare
Which wasn't reliable anyway, because it could be translated to different things depending on the system and encodings in use. PSReadLine now just discards any key input after cancellation. This requires an update to PSReadLine v2.2.3.
andyleejordan
force-pushed
the
andschwa/readkey-race
branch
from
April 20, 2022 21:56
7d21d59 to
2a12c4b
Compare
andyleejordan
marked this pull request as ready for review
April 20, 2022 21:57
daxian-dbw
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which wasn't reliable anyway, because it could be translated to different things depending on the system and encodings in use. PSReadLine now just discards any key input after cancellation.
Requires PowerShell/PSReadLine#3274 and fixes #1754.