Add DevContainer support - #1286
Merged
Christoph Bergmeister (bergmeister) merged 6 commits intoJan 28, 2020
Merged
Conversation
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
July 10, 2019 19:46
added 2 commits
January 4, 2020 18:40
… into devContainer
…trimmed out unnecessary things)
James Truher (JamesWTruher)
approved these changes
Jan 28, 2020
James Truher (JamesWTruher)
left a comment
James Truher (JamesWTruher)
left a comment
Contributor
There was a problem hiding this comment.
LGTM - please merge at your convenience
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This allows for developing in a container. Once .Net Core 3 releases its RTM version, I would like to upgrade the SDK, which will then contain PowerShell already. At the moment I have to bootstrap PowerShell myself, which is at least easier then using the PowerShell extension and bootstrapping the .Net SDK.
Dockerfile taken from .Net Core template of Docs page for VS-Code container development.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.