Repository navigation
Fix Tamil nonspacing mark cursor widths - #5216
Open
RamasubbuSK wants to merge 2 commits into
Open
RamasubbuSK wants to merge 2 commits into
RamasubbuSK wants to merge 2 commits into
Conversation
Treat Tamil nonspacing marks as zero-width while preserving spacing vowel signs. Keep attached marks with their bases during truncation, wrapping, and cursor mapping. Related to PowerShell#5215. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b17b4160-1c66-4f4f-97d0-4582f6173b80
Cover Tamil marks versus spacing vowels, the reported sentence, ANSI-colored text, cell-boundary truncation, wrapped newlines, cursor mappings, and normal/screen-reader rendering. Initialize the shared test runspace for independent width tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b17b4160-1c66-4f4f-97d0-4582f6173b80
Author
|
@microsoft-github-policy-service agree |
RamasubbuSK
marked this pull request as ready for review
September 24, 2026 02:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Keep the cursor immediately after Tamil input by treating Tamil nonspacing marks as zero-cell characters. The example in #5215 now measures 21 cells rather than 27.
Fixes #5215.
Changes
Scope and why this is a draft
This is deliberately a scoped Tamil correction, not a general Unicode grapheme implementation. Broadly making every combining mark zero-width would also change existing emoji/variation-selector accounting. ASCII, controls, East Asian width rules, and unrelated Unicode behavior are left unchanged.
It targets the reported Windows Terminal graphemes mode. General grapheme capping, canonically decomposed spacing-vowel combinations, join-control handling, emoji sequences, and terminal measurement-mode negotiation are not solved here. Maintainer feedback on this scope and interactive terminal verification are still needed.
The built module has not replaced the locally installed PSReadLine module.
Verification
Used the repository-pinned .NET SDK 8.0.415, targeting net8.0.
2984546f62da9f63c31aba965ec3008fcb107024: 478 passed, 93 failed, 326 skipped.PR Checklist
Microsoft Reviewers: Open in CodeFlow