upgrading from 2.2.0-beta2 > beta3 broke Powershell debugger in vscode #2616

Activity

1. ghost added

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on Jun 24, 2021
2. WorrenB commented on Jun 25, 2021

   

   WorrenB

   on Jun 25, 2021

   More actions

   seems to be related to PSReadLine 2.2.0-beta 3 breaks extension
   in my case I couldn't use F8 (Run Selections) either
3. andyleejordan commented on Jun 25, 2021

   

   Andy Jordan (andyleejordan)

   on Jun 25, 2021

   Member

   More actions

   brock chapin (@bchap1n) and WorrenB Can you please downgrade your PSReadLine to the latest compatible version (i.e. the one we ship with the extension) 2.1.0?

   PowerShell/vscode-powershell#3393 (comment)
4. bchap1n commented on Jun 25, 2021

   

   brock chapin (bchap1n)

   on Jun 25, 2021

   Author

   More actions

   Andy Jordan (@andschwa) 2.1.0 and 2.2.0-beta2 both work ok for me.

   The problem is that I can't use Powershell Preview 7.2.* at all without PSReadline 2.2.0-beta3 and there is no work-around for that.

   👍React with 👍1Reacted by Andy Jordan
5. andyleejordan commented on Jun 25, 2021

   

   Andy Jordan (andyleejordan)

   on Jun 25, 2021

   Member

   More actions

   The fix is going to be PowerShell/PowerShellEditorServices#1514
6. andyleejordan commented on Jun 25, 2021

   

   Andy Jordan (andyleejordan)

   on Jun 25, 2021

   Member

   More actions

   Unless, Dongbo Wang (@daxian-dbw), will PowerShell Preview 7.2.x be incompatible with PSReadLine 2.1.0 at some point? Like, what's our priority to upgrade the bundled PSReadLine to 2.2.0?

   👍React with 👍1Reacted by brock chapin
7. bchap1n commented on Jun 28, 2021

   

   brock chapin (bchap1n)

   on Jun 28, 2021

   Author

   More actions

   Andy Jordan (@andschwa) I see your question was directed at dbw but I understand that PowerShell Preview 7.2.0-preview.7 is not compatible with PSReadLine 2.1.0
8. andyleejordan commented on Jun 29, 2021

   

   Andy Jordan (andyleejordan)

   on Jun 29, 2021

   Member

   More actions

   Hm, FYI Rob Holt (@rjmholt) we might have to prioritize bumping PSReadLine.

   👍React with 👍1Reacted by Rob Holt
9. daxian-dbw commented on Jul 1, 2021

   

   Dongbo Wang (daxian-dbw)

   on Jul 1, 2021

   Member

   More actions

   will PowerShell Preview 7.2.x be incompatible with PSReadLine 2.1.0 at some point? Like, what's our priority to upgrade the bundled PSReadLine to 2.2.0?

   Yes, 2.1.0 works with all 7.2 preview releases. It's safe to bundle PSES with 2.1.0 PSReadLine.

   👍React with 👍1Reacted by Andy Jordan
10. ghost added

    In-PRA PR is opened targeting the issueA PR is opened targeting the issue

    on Jul 1, 2021
11. daxian-dbw commented on Jul 1, 2021

    

    Dongbo Wang (daxian-dbw)

    on Jul 1, 2021

    Member

    More actions

    Rob Holt (@rjmholt) found out the root cause why 2.2.0-beta3 breaks VSCode debugging:

    PSReadLine/PSReadLine/ReadLine.cs

    Lines 317 to 320 in ad74cef

    	public static string ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken)
    	{
    	return ReadLine(runspace, engineIntrinsics, _defaultCancellationToken, lastRunStatus: null);
    	}

    The cancellationToken should be passed along instead of using the default token. PR is out: #2636

    🎉React with 🎉1Reacted by Andy Jordan
12. Dongbo Wang (daxian-dbw)

    added

    Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.

    and removed

    Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

    on Jul 1, 2021
13. Dongbo Wang (daxian-dbw)

    closed this as completedin #2636on Jul 1, 2021
14. ghost removed

    In-PRA PR is opened targeting the issueA PR is opened targeting the issue

    on Jul 1, 2021
15. ghost added

    Resolution-Fixed

    on Jul 1, 2021